remove typedef to simplify code

This commit is contained in:
Evgeniy Dushistov
2013-07-07 15:24:28 +00:00
parent f9c34e438e
commit a1f5ebeee2
5 changed files with 27 additions and 31 deletions

View File

@@ -5,7 +5,7 @@
#include "file.hpp"
static void __for_each_file(const std::string& dirname, const std::string& suff,
const List& order_list, const List& disable_list,
const std::list<std::string>& order_list, const std::list<std::string>& disable_list,
const std::function<void (const std::string&, bool)>& f)
{
GDir *dir = g_dir_open(dirname.c_str(), 0, nullptr);
@@ -30,8 +30,8 @@ static void __for_each_file(const std::string& dirname, const std::string& suff,
}
void for_each_file(const List& dirs_list, const std::string& suff,
const List& order_list, const List& disable_list,
void for_each_file(const std::list<std::string>& dirs_list, const std::string& suff,
const std::list<std::string>& order_list, const std::list<std::string>& disable_list,
const std::function<void (const std::string&, bool)>& f)
{
for (const std::string & item : order_list) {

View File

@@ -4,9 +4,7 @@
#include <string>
#include <functional>
typedef std::list<std::string> List;
extern void for_each_file(const List& dirs_list, const std::string& suff,
const List& order_list, const List& disable_list,
extern void for_each_file(const std::list<std::string>& dirs_list, const std::string& suff,
const std::list<std::string>& order_list, const std::list<std::string>& disable_list,
const std::function<void (const std::string&, bool)>& f);

View File

@@ -482,7 +482,7 @@ namespace {
const gchar *get_first_on_page_key(glong page_idx);
bool load_cache(const std::string& url);
bool save_cache(const std::string& url);
static strlist_t get_cache_variant(const std::string& url);
static std::list<std::string> get_cache_variant(const std::string& url);
};
const char *OffsetIndex::CACHE_MAGIC = "StarDict's Cache, Version: 0.1";
@@ -548,7 +548,7 @@ namespace {
bool OffsetIndex::load_cache(const std::string& url)
{
const strlist_t vars = get_cache_variant(url);
const std::list<std::string> vars = get_cache_variant(url);
for (const std::string& item : vars) {
struct ::stat idxstat, cachestat;
@@ -570,9 +570,9 @@ namespace {
return false;
}
strlist_t OffsetIndex::get_cache_variant(const std::string& url)
std::list<std::string> OffsetIndex::get_cache_variant(const std::string& url)
{
strlist_t res = {url + ".oft"};
std::list<std::string> res = {url + ".oft"};
if (!g_file_test(g_get_user_cache_dir(), G_FILE_TEST_EXISTS) &&
g_mkdir(g_get_user_cache_dir(), 0700)==-1)
return res;
@@ -593,7 +593,7 @@ namespace {
bool OffsetIndex::save_cache(const std::string& url)
{
const strlist_t vars = get_cache_variant(url);
const std::list<std::string> vars = get_cache_variant(url);
for (const std::string& item : vars) {
FILE *out=fopen(item.c_str(), "wb");
if (!out)
@@ -897,9 +897,9 @@ void Libs::load_dict(const std::string& url)
delete lib;
}
void Libs::load(const strlist_t& dicts_dirs,
const strlist_t& order_list,
const strlist_t& disable_list)
void Libs::load(const std::list<std::string>& dicts_dirs,
const std::list<std::string>& order_list,
const std::list<std::string>& disable_list)
{
for_each_file(dicts_dirs, ".ifo", order_list, disable_list,
[this](const std::string& url, bool disable) -> void {
@@ -908,9 +908,9 @@ void Libs::load(const strlist_t& dicts_dirs,
});
}
void Libs::reload(const strlist_t& dicts_dirs,
const strlist_t& order_list,
const strlist_t& disable_list)
void Libs::reload(const std::list<std::string>& dicts_dirs,
const std::list<std::string>& order_list,
const std::list<std::string>& disable_list)
{
std::vector<Dict *> prev(oLib);
oLib.clear();

View File

@@ -111,8 +111,6 @@ private:
bool load_ifofile(const std::string& ifofilename, gulong &idxfilesize);
};
typedef std::list<std::string> strlist_t;
class Libs {
public:
Libs(std::function<void(void)> f = std::function<void(void)>()) {
@@ -124,12 +122,12 @@ public:
Libs& operator=(const Libs&) = delete;
void load_dict(const std::string& url);
void load(const strlist_t& dicts_dirs,
const strlist_t& order_list,
const strlist_t& disable_list);
void reload(const strlist_t& dicts_dirs,
const strlist_t& order_list,
const strlist_t& disable_list);
void load(const std::list<std::string>& dicts_dirs,
const std::list<std::string>& order_list,
const std::list<std::string>& disable_list);
void reload(const std::list<std::string>& dicts_dirs,
const std::list<std::string>& order_list,
const std::list<std::string>& disable_list);
glong narticles(int idict) const { return oLib[idict]->narticles(); }
const std::string& dict_name(int idict) const { return oLib[idict]->dict_name(); }